fix(enterKeyHint): use a fixed enterKeyHint value on Samsung devices
#916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ec86a12:
|
francoischalifour
approved these changes
Mar 8, 2022
sarahdayan
reviewed
Mar 8, 2022
packages/autocomplete-core/src/utils/__tests__/isChrome.test.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-core/src/utils/__tests__/isChrome.test.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-core/src/utils/__tests__/isChrome.test.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-core/src/utils/__tests__/isChrome.test.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-core/src/utils/__tests__/isChrome.test.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-core/src/utils/__tests__/isAndroid.test.ts
Outdated
Show resolved
Hide resolved
sarahdayan
reviewed
Mar 14, 2022
Haroenv
reviewed
Mar 14, 2022
|
@francoischalifour when can I expect this to be merged? |
|
Hey @nitech, could you try this version on your app and tell us if this effectively fixes the issue for you? You can replace your Autocomplete dependencies with these versions in your
Example: {
// ...
"dependencies": {
"@algolia/autocomplete-js": "https://pkg.csb.dev/algolia/autocomplete/commit/e772e3af/@algolia/autocomplete-js",
"@algolia/autocomplete-theme-classic": "https://pkg.csb.dev/algolia/autocomplete/commit/e772e3af/@algolia/autocomplete-theme-classic"
}
}
|
sarahdayan
reviewed
Mar 25, 2022
packages/autocomplete-core/src/utils/__tests__/isAndroid.test.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-core/src/utils/__tests__/isSamsung.test.ts
Outdated
Show resolved
Hide resolved
packages/autocomplete-core/src/utils/__tests__/isSamsung.test.ts
Outdated
Show resolved
Hide resolved
sarahdayan
reviewed
Mar 30, 2022
sarahdayan
approved these changes
Mar 30, 2022
|
@sarahdayan bug still present on user agent: Does Algolia Autocomplete allow me to turn off modifying enterKeyHint? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix #651.
Issue summary
On a Samsung device using Chrome Android with the Predictive Search feature enabled, the input value is reset when
enterKeyHintproperty is updated (between"search"and"go").Result
Based on the current user agent, we detect the device vendor (Samsung), type (mobile or tablet), OS (Android) and browser (Chrome). If all these conditions are matching (
samsung && (mobile || tablet) && android && chrome), we use a fixed"enter"value forenterKeyHintproperty.