fix: ignore composition events with option #1238
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reintegrates #1226 and sets the behaviour behind an option, as in algolia/instantsearch#6009.
Summary
Characters entered using an IME trigger search requests although the character composition is not done. This should only happen if the character has been fully composed.
This PR stops processing
input
events when composing with an IME and instead rely on thecompositionend
event in that case. This is controled by a newignoreCompositionEvents
option.It also prevents keyboard inputs being processed by Autocomplete if the user is currently navigating through suggestions in an IME.
Result
Before
After
Fixes algolia/docsearch#1304
Fixes algolia/docsearch#1043
Fixes #1135