docs(createRecentSearchesPlugin): rewrite docs #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahdayan
commented
Feb 25, 2021
sarahdayan
commented
Feb 25, 2021
sarahdayan
commented
Feb 25, 2021
|
Broken unit tests are caused by 752afd8 which broke the build. |
sarahdayan
force-pushed
the
docs/createRecentSearchesPlugin
branch
from
e852fc7 to
f8ae4c8
Compare
sarahdayan
commented
Feb 26, 2021
Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
sarahdayan
force-pushed
the
docs/createRecentSearchesPlugin
branch
from
91c418f to
3e29b2e
Compare
francoischalifour
approved these changes
Mar 1, 2021
Comment on lines
+76
to
+80
| async getAll(query) { | ||
| const items = await RecentSearchesItem.find({}); | ||
|
|
||
| return search({ query, items, limit: 5 }); | ||
| }, |
There was a problem hiding this comment.
async is not super democratized in the frontend, it requires special configuration.
Suggested change
| async getAll(query) { | |
| const items = await RecentSearchesItem.find({}); | |
| return search({ query, items, limit: 5 }); | |
| }, | |
| getAll(query) { | |
| return RecentSearchesItem.find({}).then((items) => { | |
| return search({ query, items, limit: 5 }); | |
| }); | |
| }, |
There was a problem hiding this comment.
Many browsers support async and await without transforms. Internet Explorer is the only one that doesn't, but it doesn't support the Promise constructor either so users would need transforms or polyfills for IE 11 anyway.
sarahdayan
added a commit
that referenced
this pull request
Mar 1, 2021
sarahdayan
added a commit
that referenced
this pull request
Mar 2, 2021
* docs(createLocalStorageRecentSearchesPlugin): rewrite docs * fix(createLocalStorageRecentSearchesPlugin): apply changes from #469
francoischalifour
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the
createRecentSearchesPlugindocs.I've added inline comments on some changes for easier reviewing.