fix: use user-provided panelLayout class #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this class was accepted, but didn't seem to be used anywhere...
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4d9f915:
|
Haroenv
added a commit
that referenced
this pull request
Jul 16, 2021
Thanks @ethanresnick for pointing this out! closes #627
|
Thanks for your PR! I modified the code slightly to match what's done in the rest of the code base in #628, as you can't suggest changes to files that aren't changed yet I'll make sure to mark the commit as co-authored-by :) |
Haroenv
added a commit
that referenced
this pull request
Jul 16, 2021
Thanks @ethanresnick for pointing this out! closes #627 co-authored-by: ethanresnick <ethanresnick@users.noreply.github.com>
|
Thank you @ethanresnick! |
Haroenv
added a commit
that referenced
this pull request
Jul 16, 2021
Thanks @ethanresnick for pointing this out! closes #627 co-authored-by: ethanresnick <ethanresnick@users.noreply.github.com> Co-authored-by: ethanresnick <ethanresnick@users.noreply.github.com>
|
@Haroenv Very much appreciate the fast action here. Thanks! |
|
Fix released in 1.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to pass in a custom panelLayout class, as seems to be a documented feature, but it didn't appear to be getting applied anywhere. I think this fixes the issue.