Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle late resolving promises with promise cancelation #864

Merged
merged 41 commits into from
Jan 26, 2022
Merged

fix: handle late resolving promises with promise cancelation #864

merged 41 commits into from
Jan 26, 2022

Commits on Jan 14, 2022

  1. fix: handle late resolving promises with promise cancelation

    @sarahdayan
    sarahdayan committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    6cc5451 View commit details
    Browse the repository at this point in the history

  2. feat: inline cancelable-promise

    @sarahdayan
    sarahdayan committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    f01de26 View commit details
    Browse the repository at this point in the history

  3. chore: remove dependency

    @sarahdayan
    sarahdayan committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    00526a3 View commit details
    Browse the repository at this point in the history

  4. feat: drop unused methods

    @sarahdayan
    sarahdayan committed Jan 14, 2022
    Configuration menu
    Copy the full SHA
    d40c06a View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2022

  1. feat: use functions instead of classes

    @sarahdayan
    sarahdayan committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    244c0db View commit details
    Browse the repository at this point in the history

  2. refactor: rename file

    @sarahdayan
    sarahdayan committed Jan 18, 2022
    Configuration menu
    Copy the full SHA
    7610dcc View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. fix: fix types

    @sarahdayan
    sarahdayan committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    a8d9b3e View commit details
    Browse the repository at this point in the history

  2. fix: fix inconsistent behavior

    @sarahdayan
    sarahdayan committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    65a9483 View commit details
    Browse the repository at this point in the history

  3. refactor: rename type

    @sarahdayan
    sarahdayan committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    46468ff View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. test: update tests

    @sarahdayan
    sarahdayan committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    9ad3000 View commit details
    Browse the repository at this point in the history

  2. build: bump bundle size

    @sarahdayan
    sarahdayan committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    516875c View commit details
    Browse the repository at this point in the history

  3. style: lint

    @sarahdayan
    sarahdayan committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    8e2f05a View commit details
    Browse the repository at this point in the history

  4. refactor: move things around

    @sarahdayan
    sarahdayan committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    9702ecf View commit details
    Browse the repository at this point in the history

  5. feat: remove onCancel handler

    @sarahdayan
    sarahdayan committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    7f484a7 View commit details
    Browse the repository at this point in the history

  6. refactor: rename type

    @sarahdayan
    sarahdayan committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    1eb4980 View commit details
    Browse the repository at this point in the history

  7. fix: simplify code by narrowing type

    @sarahdayan
    sarahdayan committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    4bf6c0e View commit details
    Browse the repository at this point in the history

  8. refactor: further simplify

    @sarahdayan
    sarahdayan committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    a60e0d8 View commit details
    Browse the repository at this point in the history

  9. build: adjust bundlesize

    @sarahdayan
    sarahdayan committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    6e633fd View commit details
    Browse the repository at this point in the history

  10. build: drop yarn.lock changes

    @sarahdayan
    sarahdayan committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    00b9cd0 View commit details
    Browse the repository at this point in the history

  11. refactor: alphabetize

    @sarahdayan
    sarahdayan committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    511d7e3 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. test: clean up tests

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    467ac44 View commit details
    Browse the repository at this point in the history

  2. feat: catch in promise consumer to avoid unhandled promises

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    14a70d4 View commit details
    Browse the repository at this point in the history

  3. chore: rename type and generic

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    494eb7c View commit details
    Browse the repository at this point in the history

  4. test: use terser descriptions

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    84a259f View commit details
    Browse the repository at this point in the history

  5. test: better descriptions

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    24e2a66 View commit details
    Browse the repository at this point in the history

  6. test: make the test more exhaustive

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    cef48a0 View commit details
    Browse the repository at this point in the history

  7. refactor: rename internal parameter

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    aedb8c2 View commit details
    Browse the repository at this point in the history

  8. refactor: rename type

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    267b700 View commit details
    Browse the repository at this point in the history

  9. test: refactor test

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    a431e71 View commit details
    Browse the repository at this point in the history

  10. test: further test concurrency behavior

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    dcc7d23 View commit details
    Browse the repository at this point in the history

  11. refactor: inline item removal

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    971eeb0 View commit details
    Browse the repository at this point in the history

  12. feat: remove runWhenCanceled option

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    d68de50 View commit details
    Browse the repository at this point in the history

  13. feat: clear callbacks once triggered

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    3d65e25 View commit details
    Browse the repository at this point in the history

  14. test: add missing test in both suites

    @sarahdayan
    sarahdayan committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    5163e7d View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. fix: s/running/pending/

    @sarahdayan
    sarahdayan committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    de4a205 View commit details
    Browse the repository at this point in the history

  2. refactor: always pass all parameters and avoid defaults

    @sarahdayan
    sarahdayan committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    ffd16fe View commit details
    Browse the repository at this point in the history

  3. fix: avoid swallowing errors and return promise chain instead

    @sarahdayan
    sarahdayan committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    c14844c View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. fix: apply suggestions from code review 

    Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
    @sarahdayan @francoischalifour
    sarahdayan and francoischalifour authored Jan 26, 2022
    Configuration menu
    Copy the full SHA
    6038735 View commit details
    Browse the repository at this point in the history

  2. build: adjust bundlesize

    @sarahdayan
    sarahdayan committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    d6b9d64 View commit details
    Browse the repository at this point in the history

  3. chore(cancelable): simplify code (#876)

    @Haroenv
    Haroenv authored Jan 26, 2022
    Configuration menu
    Copy the full SHA
    5735c23 View commit details
    Browse the repository at this point in the history

  4. build: adjust bundlesize

    @sarahdayan
    sarahdayan committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    4fc760a View commit details
    Browse the repository at this point in the history