Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

Fix icon selector #2736

Merged
merged 3 commits into from
Nov 9, 2020
Merged

Fix icon selector #2736

merged 3 commits into from
Nov 9, 2020

Conversation

shortcuts
Copy link
Member

Pull request motivation(s)

What is the current behaviour?

If the current behaviour is a bug, please provide all the steps to reproduce and screenshots with context.

What is the expected behaviour?

NB: Do you want to request a feature or report a bug?
NB2: Any other feedback / questions ?

@shortcuts shortcuts merged commit 5eeb53a into master Nov 9, 2020
@shortcuts shortcuts deleted the conf/bootstrap-icons branch November 9, 2020 11:44
@XhmikosR
Copy link
Contributor

XhmikosR commented Nov 9, 2020

I was wondering, what is the point of having getbootstrap.com specific stuff in this config? icons and the main site are different projects?

@shortcuts
Copy link
Member Author

This config was only made for the POC (twbs/bootstrap#32098) of having getbootstrap.com doc and the icons under the same search.

@XhmikosR
Copy link
Contributor

XhmikosR commented Nov 9, 2020

Oh, OK. Because these are different projects thus it doesn't make sense to keep the same config.

@shortcuts
Copy link
Member Author

Sure, we thought that it was a good idea to merge them with the new DocSearch v3, but now that it's clear, I'll separate them and send you the details asap.

@XhmikosR
Copy link
Contributor

XhmikosR commented Nov 9, 2020

Thanks :) Let me know the details and I'll try to work on it ASAP.

BTW is v1.0.0 stable enough? Also, do note that for v4, which is what getbootstrap.com currently uses, we support old browsers so we might have compatibility issues with newer JS. For v5, we can make the switch and when we hit stable/beta and move to the main domain, it shouldn't matter anymore :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants