Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance contribution and use without docker #410

Closed
wants to merge 31 commits into from

Conversation

s-pace
Copy link
Contributor

@s-pace s-pace commented Nov 2, 2018

Introducing the use of pipenv to ease the way to use our tool outside Docker

cc #403

CONTRIBUTING.md Outdated Show resolved Hide resolved
cli/oh-my-zsh/README.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
@pixelastic
Copy link
Contributor

And you should also remove requirements.txt now that we have Pipfile, it's no longer needed.

pixelastic
pixelastic previously approved these changes Nov 6, 2018
@pixelastic
Copy link
Contributor

Ah wait, you need to update the Travis scripts before merging. They use requirements.txt. They now need to use pipenv

@s-pace
Copy link
Contributor Author

s-pace commented Nov 6, 2018

let's keep requirement.txt then. It is pretty convenient for both usage.

@pixelastic
Copy link
Contributor

Having both a Pipfile and a requirements.txt will be confusing for new users (as they might install the wrong set of dependencies), and we will also have trouble keeping them in sync. Pipfile being a better alternative than requirements.txt we should make sure that our CI uses this setup.

Do you need help with that?

@s-pace
Copy link
Contributor Author

s-pace commented Nov 6, 2018

@pixelastic makes sense. Please update Travis then. I do not know how to do it.

🙏

@pixelastic
Copy link
Contributor

Ok, I'll have a look.

pixelastic
pixelastic previously approved these changes Nov 7, 2018
@pixelastic
Copy link
Contributor

@s-pace @maxiloc Could you re-explain how DocSearch works with the different python versions?

I see that the new Pipfile uses python 2.7, and I know I can only run ./docsearch personally when I'm using python 2.7. But I see that the Travis build sets a USE_PYTHON3 to true and the subsequent docker image create uses python 3 for the tests. I also see we have a bunch of compatibility layers (future, six).

Why do we have this mix of python 2 and 3, and what is the recommended version for running DocSearch? My understanding was that DocSearch uses mostly python 2, but we would like to move to python 3 at some point, but the code would need a big rehaul to do so. Could you clarify the current state?

Thanks!

@s-pace
Copy link
Contributor Author

s-pace commented Nov 7, 2018

The scraper only works with python 2.7. I do not know why this env is set

@s-pace
Copy link
Contributor Author

s-pace commented Nov 19, 2018

Closing it in favor of #411

@s-pace s-pace closed this Nov 19, 2018
@pixelastic pixelastic deleted the feat/better_deployment_workflow branch November 20, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants