-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance contribution and use without docker #410
Conversation
And you should also remove |
Ah wait, you need to update the Travis scripts before merging. They use |
let's keep requirement.txt then. It is pretty convenient for both usage. |
Having both a Do you need help with that? |
@pixelastic makes sense. Please update Travis then. I do not know how to do it. 🙏 |
Ok, I'll have a look. |
Co-Authored-By: s-pace <sylvain.pace@algolia.com>
Co-Authored-By: s-pace <sylvain.pace@algolia.com>
4e2e088
to
7af1a39
Compare
Co-Authored-By: s-pace <sylvain.pace@algolia.com>
Co-Authored-By: s-pace <sylvain.pace@algolia.com>
…docsearch-scraper into feat/better_deployment_workflow
@s-pace @maxiloc Could you re-explain how DocSearch works with the different python versions? I see that the new Pipfile uses python 2.7, and I know I can only run Why do we have this mix of python 2 and 3, and what is the recommended version for running DocSearch? My understanding was that DocSearch uses mostly python 2, but we would like to move to python 3 at some point, but the code would need a big rehaul to do so. Could you clarify the current state? Thanks! |
The scraper only works with python 2.7. I do not know why this env is set |
Closing it in favor of #411 |
Introducing the use of
pipenv
to ease the way to use our tool outside Dockercc #403