-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(footer): make SVG accessible #1306
Conversation
✔️ Deploy Preview for docsearch ready! 🔨 Explore the source changes: d05c341 🔍 Inspect the deploy log: https://app.netlify.com/sites/docsearch/deploys/6214a49be8279f00087411fe 😎 Browse the preview: https://deploy-preview-1306--docsearch.netlify.app |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d05c341:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not entirely sure it's relevant to make the svg accessible if we have a better describe
somewhere else.
Not an expert though, maybe @SaraSoueidan has feedbacks on this?
<svg width="" height="" viewBox="" aria-hidden="false"></svg>
<span class="visually-hidden">Algolia</span> That said, I do prefer adding a label to the SVG in this case to match the visual experience with the SR experience. You'll want to remember to add
|
Thanks for the reply and advices @SaraSoueidan! I've actually used your blog article to pick between the multiple solutions :D
Ok so if I understand correctly, the
I've removed it from the logo and it indeed does not changed the SR/tabs behaviors. |
Summary
After feedbacks from https://twitter.com/SaraSoueidan/status/1491487611831173131, this PR aims at making the footer SVGs accessible.
keys
or theAlgolia
logo or were not announced by screen readers, this should fix it but I'm not sure if it's the most optimal way to do it.