Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (api): Adds ability for click insights events to be triggered #1916

Merged
merged 8 commits into from
Jun 15, 2023
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bundlesize.config.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@
},
{
"path": "packages/docsearch-react/dist/umd/index.js",
"maxSize": "22.47 kB"
"maxSize": "22.57 kB"
},
{
"path": "packages/docsearch-js/dist/umd/index.js",
"maxSize": "30.33 kB"
"maxSize": "30.43 kB"
}
]
}
34 changes: 31 additions & 3 deletions packages/docsearch-react/src/DocSearchModal.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import type { AutocompleteState } from '@algolia/autocomplete-core';
import { createAutocomplete } from '@algolia/autocomplete-core';
import {
type AlgoliaInsightsHit,
createAutocomplete,
} from '@algolia/autocomplete-core';
import React from 'react';

import { MAX_QUERY_SIZE } from './constants';
Expand All @@ -14,6 +16,7 @@ import { SearchBox } from './SearchBox';
import { createStoredSearches } from './stored-searches';
import type {
DocSearchHit,
DocSearchState,
InternalDocSearchHit,
StoredDocSearchHit,
} from './types';
Expand Down Expand Up @@ -66,7 +69,7 @@ export function DocSearchModal({
...screenStateTranslations
} = translations;
const [state, setState] = React.useState<
AutocompleteState<InternalDocSearchHit>
DocSearchState<InternalDocSearchHit>
>({
query: '',
collections: [],
Expand Down Expand Up @@ -130,6 +133,28 @@ export function DocSearchModal({
[favoriteSearches, recentSearches, disableUserPersonalization]
);

const sendItemClickEvent = React.useCallback(
(item: InternalDocSearchHit) => {
if (!state.context.algoliaInsightsPlugin || !item.__autocomplete_id)
return;

const insightsItem = item as AlgoliaInsightsHit;

const insightsClickParams = {
eventName: 'Item Selected',
index: insightsItem.__autocomplete_indexName,
items: [insightsItem],
positions: [item.__autocomplete_id],
queryID: insightsItem.__autocomplete_queryID,
};

state.context.algoliaInsightsPlugin.insights.clickedObjectIDsAfterSearch(
insightsClickParams
);
},
[state.context.algoliaInsightsPlugin]
);

const autocomplete = React.useMemo(
() =>
createAutocomplete<
Expand Down Expand Up @@ -476,6 +501,9 @@ export function DocSearchModal({
translations={screenStateTranslations}
getMissingResultsUrl={getMissingResultsUrl}
onItemClick={(item, event) => {
// If insights is active, send insights click event
sendItemClickEvent(item);

saveRecentSearch(item);
if (!isModifierEvent(event)) {
onClose();
Expand Down
6 changes: 5 additions & 1 deletion packages/docsearch-react/src/Hit.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,9 @@ interface HitProps {
}

export function Hit({ hit, children }: HitProps) {
return <a href={hit.url}>{children}</a>;
return (
<a href={hit.url} onClick={(e) => e.preventDefault()}>
8bittitan marked this conversation as resolved.
Show resolved Hide resolved
8bittitan marked this conversation as resolved.
Show resolved Hide resolved
{children}
</a>
);
}
1 change: 1 addition & 0 deletions packages/docsearch-react/src/types/DocSearchHit.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,5 @@ export declare type DocSearchHit = {
appId: string;
apiKey: string;
};
__autocomplete_id?: number;
};
17 changes: 17 additions & 0 deletions packages/docsearch-react/src/types/DocSearchState.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import type {
AutocompleteContext,
AutocompleteInsightsApi,
AutocompleteState,
BaseItem,
} from '@algolia/autocomplete-core';

interface DocSearchContext extends AutocompleteContext {
algoliaInsightsPlugin?: {
insights: AutocompleteInsightsApi;
};
}

export interface DocSearchState<TItem extends BaseItem>
extends AutocompleteState<TItem> {
context: DocSearchContext;
}
1 change: 1 addition & 0 deletions packages/docsearch-react/src/types/index.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
export * from './DocSearchHit';
export * from './DocSearchState';
export * from './InternalDocSearchHit';
export * from './StoredDocSearchHit';