Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a good eslint config #38

Open
bobylito opened this issue Mar 13, 2017 · 4 comments
Open

Set a good eslint config #38

bobylito opened this issue Mar 13, 2017 · 4 comments

Comments

@bobylito
Copy link
Contributor

ESlint is enforced in this project but:

  • the configuration is outdated
  • too many projects don't follow the rules

If we want to continue using eslint we need a virtuous circle where the project is clean before and when there is a PR it will have to follow because it was clean before :)

@Haroenv Haroenv changed the title Make ESlint great again Set a good eslint config Mar 13, 2017
@pixelastic
Copy link
Contributor

I think whole repo should be split into several submodules, one for each example, and each one having its own set of ESLint rules. In the end, we'll be able to remove ESLint from this master project, and have it independently on each submodule.

@seafoox
Copy link
Member

seafoox commented Mar 14, 2017

How having several submodules would help with the ESLint rules?

@pixelastic
Copy link
Contributor

pixelastic commented Mar 15, 2017 via email

@bobylito
Copy link
Contributor Author

Each one will have his own, relevant, set of rules. It will also be easier to fix the linting issue one submodule at a time

For easing the contribution, we should go for a single unified configuration. However I agree that we don't need to do that in a single iteration. Having configuration per project then moving to a single one feels like the best way to ensure we are moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants