Skip to content

Commit

Permalink
feat: drop suppot for onHistoryChange (#3941)
Browse files Browse the repository at this point in the history
  • Loading branch information
samouss authored and Haroenv committed Oct 23, 2019
1 parent 2611da5 commit 697f609
Show file tree
Hide file tree
Showing 23 changed files with 0 additions and 121 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ describe('connectGeoSearch', () => {
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const { refine } = render.mock.calls[0][0];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -427,7 +427,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hierarchica
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

// test that rendering has been called during init with isFirstRendering = true
Expand Down Expand Up @@ -473,7 +472,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hierarchica
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const firstRenderingOptions = rendering.mock.calls[0][0];
Expand Down Expand Up @@ -514,7 +512,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hierarchica
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

// During the first rendering there are no facet values
Expand Down Expand Up @@ -683,7 +680,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hierarchica
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const { refine } = rendering.mock.calls[0][0];
Expand Down Expand Up @@ -800,7 +796,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hierarchica
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

widget.render({
Expand Down Expand Up @@ -912,7 +907,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hierarchica
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

widget.render({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits-per-pa
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

expect(renderFn).toHaveBeenCalledTimes(1);
Expand Down Expand Up @@ -192,7 +191,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits-per-pa
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const firstRenderOptions = renderFn.mock.calls[0][0];
Expand Down Expand Up @@ -275,7 +273,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits-per-pa
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const firstRenderOptions = renderFn.mock.calls[0][0];
Expand Down Expand Up @@ -312,7 +309,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits-per-pa
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const firstRenderOptions = renderFn.mock.calls[0][0];
Expand Down Expand Up @@ -355,7 +351,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits-per-pa
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const firstRenderOptions = renderFn.mock.calls[0][0];
Expand Down Expand Up @@ -398,7 +393,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits-per-pa
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const firstRenderOptions = renderFn.mock.calls[0][0];
Expand Down Expand Up @@ -501,7 +495,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits-per-pa
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const { refine } = renderFn.mock.calls[0][0];
Expand Down
5 changes: 0 additions & 5 deletions src/connectors/hits/__tests__/connectHits-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits/js/#co
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

expect(renderFn).toHaveBeenCalledTimes(1);
Expand Down Expand Up @@ -86,7 +85,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits/js/#co
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

expect(renderFn).toHaveBeenLastCalledWith(
Expand Down Expand Up @@ -131,7 +129,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits/js/#co
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

expect(renderFn).toHaveBeenLastCalledWith(
Expand Down Expand Up @@ -195,7 +192,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits/js/#co
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

expect(renderFn).toHaveBeenNthCalledWith(
Expand Down Expand Up @@ -239,7 +235,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits/js/#co
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const hits = [{ name: 'name 1' }, { name: 'name 2' }];
Expand Down
7 changes: 0 additions & 7 deletions src/connectors/menu/__tests__/connectMenu-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/menu/js/#co
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

// test that rendering has been called during init with isFirstRendering = true
Expand Down Expand Up @@ -172,7 +171,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/menu/js/#co
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const firstRenderingOptions = rendering.mock.calls[0][0];
Expand Down Expand Up @@ -211,7 +209,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/menu/js/#co
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

// During the first rendering there are no facet values
Expand Down Expand Up @@ -394,7 +391,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/menu/js/#co
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

expect(rendering).toHaveBeenLastCalledWith(
Expand Down Expand Up @@ -425,7 +421,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/menu/js/#co
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

widget.render({
Expand Down Expand Up @@ -490,7 +485,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/menu/js/#co
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

widget.render({
Expand Down Expand Up @@ -538,7 +532,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/menu/js/#co
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const { refine } = rendering2.mock.calls[0][0];
Expand Down
10 changes: 0 additions & 10 deletions src/connectors/numeric-menu/__tests__/connectNumericMenu-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/numeric-men
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

// test that rendering has been called during init with isFirstRendering = true
Expand Down Expand Up @@ -138,7 +137,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/numeric-men
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

expect(rendering).toHaveBeenLastCalledWith(
Expand Down Expand Up @@ -184,7 +182,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/numeric-men
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const firstRenderingOptions = rendering.mock.calls[0][0];
Expand Down Expand Up @@ -263,7 +260,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/numeric-men
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

expect(rendering).toHaveBeenLastCalledWith(
Expand Down Expand Up @@ -326,7 +322,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/numeric-men
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

let refine =
Expand Down Expand Up @@ -379,7 +374,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/numeric-men
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const refine =
Expand Down Expand Up @@ -443,7 +437,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/numeric-men
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const firstRenderingOptions = rendering.mock.calls[0][0];
Expand Down Expand Up @@ -488,7 +481,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/numeric-men
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

expect(helper.state.page).toBe(2);
Expand Down Expand Up @@ -523,7 +515,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/numeric-men
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

expect(helper.state.page).toBeUndefined();
Expand Down Expand Up @@ -576,7 +567,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/numeric-men
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const { refine } = rendering.mock.calls[0][0];
Expand Down
5 changes: 0 additions & 5 deletions src/connectors/pagination/__tests__/connectPagination-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/pagination/
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

{
Expand Down Expand Up @@ -91,7 +90,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/pagination/
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

{
Expand Down Expand Up @@ -136,7 +134,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/pagination/
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

// page 0
Expand Down Expand Up @@ -202,7 +199,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/pagination/
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

widget.render({
Expand Down Expand Up @@ -322,7 +318,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/pagination/
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const { refine } = renderFn.mock.calls[0][0];
Expand Down
6 changes: 0 additions & 6 deletions src/connectors/range/__tests__/connectRange-test.js
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/range-input
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

{
Expand Down Expand Up @@ -164,7 +163,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/range-input
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

{
Expand Down Expand Up @@ -233,7 +231,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/range-input
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

{
Expand Down Expand Up @@ -273,7 +270,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/range-input
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

{
Expand Down Expand Up @@ -310,7 +306,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/range-input
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

{
Expand Down Expand Up @@ -934,7 +929,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/range-input
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const { refine } = rendering.mock.calls[0][0];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/rating-menu
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

{
Expand Down Expand Up @@ -157,7 +156,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/rating-menu
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

{
Expand Down Expand Up @@ -262,7 +260,6 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/rating-menu
helper,
state: helper.state,
createURL: () => '#',
onHistoryChange: () => {},
});

const { refine } = rendering.mock.calls[0][0];
Expand Down
Loading

0 comments on commit 697f609

Please sign in to comment.