fix(hits): update lifecycle state (#3977)

algolia · Oct 23, 2019 · 6e55ba6 · 6e55ba6
1 parent d21d620
commit 6e55ba6
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 11 deletions.
diff --git a/src/connectors/hits/__tests__/connectHits-test.js b/src/connectors/hits/__tests__/connectHits-test.js
@@ -1,4 +1,7 @@
-import algoliasearchHelper, { SearchResults } from 'algoliasearch-helper';
+import algoliasearchHelper, {
+  SearchParameters,
+  SearchResults,
+} from 'algoliasearch-helper';
 import { TAG_PLACEHOLDER } from '../../../lib/escape-highlight';
 import connectHits from '../connectHits';
 
@@ -43,10 +46,12 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits/js/#co
     const makeWidget = connectHits(renderFn);
     const widget = makeWidget({ escapeHTML: true });
 
-    expect(widget.getConfiguration()).toEqual({
-      highlightPreTag: TAG_PLACEHOLDER.highlightPreTag,
-      highlightPostTag: TAG_PLACEHOLDER.highlightPostTag,
-    });
+    expect(widget.getConfiguration(new SearchParameters({}))).toEqual(
+      new SearchParameters({
+        highlightPreTag: TAG_PLACEHOLDER.highlightPreTag,
+        highlightPostTag: TAG_PLACEHOLDER.highlightPostTag,
+      })
+    );
 
     // test if widget is not rendered yet at this point
     expect(renderFn).toHaveBeenCalledTimes(0);
@@ -85,10 +90,12 @@ See documentation: https://www.algolia.com/doc/api-reference/widgets/hits/js/#co
     const makeWidget = connectHits(renderFn);
     const widget = makeWidget();
 
-    expect(widget.getConfiguration()).toEqual({
-      highlightPreTag: TAG_PLACEHOLDER.highlightPreTag,
-      highlightPostTag: TAG_PLACEHOLDER.highlightPostTag,
-    });
+    expect(widget.getConfiguration(new SearchParameters({}))).toEqual(
+      new SearchParameters({
+        highlightPreTag: TAG_PLACEHOLDER.highlightPreTag,
+        highlightPostTag: TAG_PLACEHOLDER.highlightPostTag,
+      })
+    );
   });
 
   it('Provides the hits and the whole results', () => {

diff --git a/src/connectors/hits/connectHits.js b/src/connectors/hits/connectHits.js
@@ -60,8 +60,12 @@ export default function connectHits(renderFn, unmountFn = noop) {
     return {
       $$type: 'ais.hits',
 
-      getConfiguration() {
-        return escapeHTML ? TAG_PLACEHOLDER : undefined;
+      getConfiguration(state) {
+        if (!escapeHTML) {
+          return state;
+        }
+
+        return state.setQueryParameters(TAG_PLACEHOLDER);
       },
 
       init({ instantSearchInstance }) {