fix(types): improve conditional for client version (algolia/algoliase…

…arch-helper-js#943) * fix(types): improve conditional for client version in TypeScript 5.1.3, the check `any extends T` when T is any no longer evaluates to one branch of the conditional, but the union of both branches. This is fixed by using a "never possible to be true, unless T is any" condition as in https://stackoverflow.com/a/49928360/3185307 fixes #5658 FX-2396 * chore(dev): update typescript this showed the error before the previous commit as ``` test/types.ts:16:7 - error TS2345: Argument of type '{ query: string; }' is not assignable to parameter of type 'PlainSearchParameters'. Object literal may only specify known properties, and 'query' does not exist in type 'PlainSearchParameters'. 16 query: 'something fun', ~~~~~ Found 1 error in test/types.ts:16 error Command failed with exit code 2. ```
algolia · Jun 13, 2023 · 8119805 · 8119805
1 parent e5d3643
commit 8119805
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/packages/algoliasearch-helper/package.json b/packages/algoliasearch-helper/package.json
@@ -69,7 +69,7 @@
     "metalsmith-metallic": "1.0.0",
     "@metalsmith/sass": "1.4.0",
     "pug": "2.0.3",
-    "typescript": "4.6.2"
+    "typescript": "5.1.3"
   },
   "dependencies": {
     "@algolia/events": "^4.0.1"

diff --git a/packages/algoliasearch-helper/types/algoliasearch.d.ts b/packages/algoliasearch-helper/types/algoliasearch.d.ts
@@ -12,7 +12,8 @@ import type * as AlgoliaSearch from 'algoliasearch';
 import type * as ClientSearch from '@algolia/client-search';
 
 // turns any to unknown, so it can be used as a conditional
-type AnyToUnknown<T> = (any extends T ? true : false) extends true
+// more info in https://stackoverflow.com/a/49928360/3185307
+type AnyToUnknown<T> = (0 extends 1 & T ? true : false) extends true
   ? unknown
   : T;
 

diff --git a/packages/algoliasearch-helper/yarn.lock b/packages/algoliasearch-helper/yarn.lock
@@ -7851,10 +7851,10 @@ typedarray@^0.0.6, typedarray@~0.0.5:
   resolved "https://registry.yarnpkg.com/typedarray/-/typedarray-0.0.6.tgz#867ac74e3864187b1d3d47d996a78ec5c8830777"
   integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=
 
-typescript@4.6.2:
-  version "4.6.2"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.6.2.tgz#fe12d2727b708f4eef40f51598b3398baa9611d4"
-  integrity sha512-HM/hFigTBHZhLXshn9sN37H085+hQGeJHJ/X7LpBWLID/fbc2acUMfU+lGD98X81sKP+pFa9f0DZmCwB9GnbAg==
+typescript@5.1.3:
+  version "5.1.3"
+  resolved "https://registry.npmjs.org/typescript/-/typescript-5.1.3.tgz#8d84219244a6b40b6fb2b33cc1c062f715b9e826"
+  integrity sha512-XH627E9vkeqhlZFQuL+UsyAXEnibT0kWR2FWONlr4sTjvxyJYnyefgrkyECLzM5NenmKzRAy2rR/OlYLA1HkZw==
 
 typical@^2.4.2, typical@^2.6.0, typical@^2.6.1:
   version "2.6.1"