fix(geoSearch): correct type of MarkerOptions (#6319)

* fix(geoSearch): correct type of MarkerOptions This isn't really exposed to the user, but I believe this broke when they moved from a namespace to an interface. fixes #6253 * fix type not sure why reported now, but seems fine * ignore as it seems to work
algolia · Aug 12, 2024 · 849190e · 849190e
1 parent 979540e
commit 849190e
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 6 deletions.
diff --git a/packages/instantsearch.js/package.json b/packages/instantsearch.js/package.json
@@ -28,7 +28,7 @@
   "dependencies": {
     "@algolia/events": "^4.0.1",
     "@types/dom-speech-recognition": "^0.0.1",
-    "@types/google.maps": "^3.45.3",
+    "@types/google.maps": "^3.55.12",
     "@types/hogan.js": "^3.0.0",
     "@types/qs": "^6.5.3",
     "algoliasearch-helper": "3.22.3",

diff --git a/packages/instantsearch.js/src/widgets/geo-search/GeoSearchRenderer.d.ts b/packages/instantsearch.js/src/widgets/geo-search/GeoSearchRenderer.d.ts
@@ -29,7 +29,7 @@ type GeoSearchRendererParams = {
   cssClasses: ComponentCSSClasses<GeoSearchWidgetParams['cssClasses']>;
   createMarker: CreateMarker;
   markerOptions: GeoSearchMarker<
-    typeof google.maps.MarkerOptions | Partial<HTMLMarkerArguments>
+    google.maps.MarkerOptions | Partial<HTMLMarkerArguments>
   >;
   enableRefine: GeoSearchWidgetParams['enableRefine'];
   enableClearMapRefinement: GeoSearchWidgetParams['enableClearMapRefinement'];

diff --git a/packages/instantsearch.js/src/widgets/geo-search/__tests__/geo-search-test.ts b/packages/instantsearch.js/src/widgets/geo-search/__tests__/geo-search-test.ts
@@ -132,6 +132,7 @@ describe('GeoSearch', () => {
     lastRenderArgs(fn).widgetParams.renderState;
 
   const simulateMapReadyEvent = (google: typeof window['google']) => {
+    // eslint-disable-next-line jest/unbound-method
     castToJestMock(google.maps.event.addListenerOnce).mock.calls[0][2]();
   };
 

diff --git a/yarn.lock b/yarn.lock
@@ -6323,10 +6323,10 @@
     "@types/minimatch" "*"
     "@types/node" "*"
 
-"@types/google.maps@^3.45.3":
-  version "3.45.6"
-  resolved "https://registry.yarnpkg.com/@types/google.maps/-/google.maps-3.45.6.tgz#441a7bc76424243b307596fc8d282a435a979ebd"
-  integrity sha512-BzGzxs8UXFxeP8uN/0nRgGbsbpYQxSCKsv/7S8OitU7wwhfFcqQSm5aAcL1nbwueMiJ/VVmIZKPq69s0kX5W+Q==
+"@types/google.maps@^3.55.12":
+  version "3.55.12"
+  resolved "https://registry.yarnpkg.com/@types/google.maps/-/google.maps-3.55.12.tgz#66b50be48533d116dddb3d705d277d06457735b0"
+  integrity sha512-Q8MsLE+YYIrE1H8wdN69YHHAF8h7ApvF5MiMXh/zeCpP9Ut745mV9M0F4X4eobZ2WJe9k8tW2ryYjLa87IO2Sg==
 
 "@types/googlemaps@^3.30.16":
   version "3.30.16"