fix(vue-instantsearch): only render list in <refinement-list> when …

…it has items (#6092)
algolia · Mar 18, 2024 · 9a38de0 · 9a38de0
1 parent 04fd202
commit 9a38de0
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/packages/vue-instantsearch/src/components/RefinementList.vue b/packages/vue-instantsearch/src/components/RefinementList.vue
@@ -30,7 +30,7 @@
       >
         <div :class="suit('noResults')">No results.</div>
       </slot>
-      <ul :class="suit('list')">
+      <ul v-if="items.length > 0" :class="suit('list')">
         <li
           :class="[suit('item'), item.isRefined && suit('item', 'selected')]"
           v-for="item in items"

diff --git a/packages/vue-instantsearch/src/components/__tests__/__snapshots__/RefinementList.js.snap b/packages/vue-instantsearch/src/components/__tests__/__snapshots__/RefinementList.js.snap
@@ -155,8 +155,6 @@ exports[`allows search bar classes override when it's searchable 1`] = `
 
 exports[`renders correctly (empty) 1`] = `
 <div class="ais-RefinementList ais-RefinementList--noRefinement">
-  <ul class="ais-RefinementList-list">
-  </ul>
 </div>
 `;
-Original file line number
+Diff line change
@@ Expand Up @@
     exports[`renders correctly (empty) 1`] = `
     <div class="ais-RefinementList ais-RefinementList--noRefinement">
-      <ul class="ais-RefinementList-list">
-      </ul>
     </div>
     `;
@@ Expand Down @@