-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I am using latest version of angular-instant search and this version of instant search is causing issue in application startup #5109
Comments
Hey @Sharma1Krishna, what's the "an issue"? Do you have a sandbox that reproduces what happens? |
Let me create one, I was using local earlier |
It was working earlier but it stopped when https://socket.dev/npm/package/instantsearch.js/overview/4.46.0 this version got published I am using these two libraries in my local here angular-instantsearch is dependent on instantsearch.js |
you can try creating a new application in your local with angular version 13 with these two libraries and you will get this issue when you do ng serve |
Because of this issue, our whole team is blocked for the development of algolia-related stories, please help us asap. |
I tried lowering the version of these libraries and it is working at "algoliasearch": "4.12.0", and need to add one dev dependency |
@types/algoliasearch doesn't need to exist, algoliasearch, angular-instantsearch and instantsearch.js come with their builtin definitions |
could you please try producing this issue in your local once with following version of libraries in a new anglar 13 version application? "algoliasearch": "^4.14.1", |
angular-tour-of-heroes.zip extract it and run "yarn install" and "ng serve" |
@Haroenv any update on this? |
Hi @Sharma1Krishna, I'm taking over for this week, Thank you for providing this example. I ran it and got the same error messages. While we fix this on our end, a quick fix would be to run this in your terminal : |
It will be fixed with tomorrow's release @Sharma1Krishna |
The fix is released in 4.46.2 |
* fix(shared): make usable when there's no preact or react see algolia/angular-instantsearch#968, algolia/angular-instantsearch#967 and algolia/instantsearch#5109 * Update packages/shared/src/Renderer.ts Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com> * avoid usage of JSX.IntrinsicElements, as it can fall back to empty interface eg. in the case there's no JSX set (angular, vue) * add a bit more text Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
🐛 Bug description
🔍 Bug reproduction
Steps to reproduce the behavior:
...
...
...
Live reproduction:
https://codesandbox.io/s/github/algolia/create-instantsearch-app/tree/templates/instantsearch.js
💭 Expected behavior
🖥 Screenshots
Environment
Additional context
The text was updated successfully, but these errors were encountered: