feat(metadata): register metadata around middleware #5492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 41b7629:
|
Haroenv
force-pushed
the
feat/automatic-insights-middleware
branch
from
5b35140 to
3d7aa28
Compare
Base automatically changed from
feat/automatic-insights-middleware
to
feat/automatic-insights
February 23, 2023 10:56
We don't know the parameters passed by the users, as it's defaulted early on in the arguments and there's no equivalent to getWidgetRenderState().widgetParams
Haroenv
force-pushed
the
feat/telemetry-middleware-as-widgets
branch
from
00ba10e to
81c934c
Compare
Haroenv
force-pushed
the
feat/telemetry-middleware-as-widgets
branch
from
81c934c to
41b7629
Compare
Haroenv
requested review from
a team,
FabienMotte and
sarahdayan
and removed request for
a team
FabienMotte
approved these changes
Feb 27, 2023
sarahdayan
approved these changes
Feb 28, 2023
Haroenv
added a commit
that referenced
this pull request
Mar 2, 2023
Haroenv
added a commit
that referenced
this pull request
Mar 2, 2023
Haroenv
added a commit
that referenced
this pull request
Mar 8, 2023
Haroenv
added a commit
that referenced
this pull request
Apr 18, 2023
Haroenv
added a commit
that referenced
this pull request
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Since
$$typeand$$internalare added in #5488, we can use this to give some information around middleware in metadataResult
A new type of
widgetsis available, with a shape like this:{ "widgets": [{ "middleware": true, "type": "ais.insights", "internal": false }] }We don't know the parameters passed by the users, as it's defaulted early on in the arguments and there's no equivalent to getWidgetRenderState().widgetParams.
However, in the router middleware, the router and state mapping are also identified in the
$$typeThis is the same as #5491, but in the existing
widgetskey.