feat(insights): automatically add insights middleware #5488
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3d7aa28:
|
Haroenv
requested review from
a team,
sarahdayan and
aymeric-giraudet
and removed request for
a team
|
Nice ! 🙌 |
Haroenv
force-pushed
the
feat/automatic-insights-allow-auto
branch
from
4685922 to
de9bf32
Compare
Haroenv
force-pushed
the
feat/automatic-insights-middleware
branch
from
5fc27cb to
5b35140
Compare
the insights middleware is added now for downstream
Haroenv
force-pushed
the
feat/automatic-insights-middleware
branch
from
5b35140 to
3d7aa28
Compare
| // This is the default middleware, | ||
| // any user-provided middleware will be added later and override this one. | ||
| this.use(createInsightsMiddleware({ $$internal: true })); |
There was a problem hiding this comment.
something still needs to be fixed here, the script is always loaded from the internal middleware, even if users add a different middleware later (even right after). Not too sure how to fix that yet
There was a problem hiding this comment.
solved through #5493
| function normalizeState(state: PlainSearchParameters) { | ||
| const { clickAnalytics, userToken, ...rest } = state || {}; | ||
| return rest; | ||
| } |
There was a problem hiding this comment.
if infiniteHits is added before start, it's reading from the cache before the insights middleware is started, and thus it doesn't have clickAnalytics + userToken yet
There was a problem hiding this comment.
to solve this, we could change some things about the insights middleware to make sure we have the search parameters right away, even before init, but that's currently not possible yet (helper is null)
| if (isMetadataEnabled()) { | ||
| this.use(createMetadataMiddleware()); | ||
| this.use(createMetadataMiddleware({ $$internal: true })); |
There was a problem hiding this comment.
Nitpick: this is technically always internal, it could be set statically in createMetadataMiddleware().
Summary
Automatically add the insights middleware
Result
FX-2248
clickAnalytics: true