feat(insights): option to disable automatic insights middleware #5493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c76dd8e:
|
Haroenv
changed the title
Haroenv
requested review from
a team,
FabienMotte and
aymeric-giraudet
and removed request for
a team
This was referenced Feb 21, 2023
Haroenv
changed the title
sarahdayan
approved these changes
Feb 21, 2023
FabienMotte
reviewed
Feb 22, 2023
FabienMotte
approved these changes
Feb 22, 2023
Base automatically changed from
feat/automatic-insights-middleware
to
feat/automatic-insights
February 23, 2023 10:56
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Haroenv
force-pushed
the
feat/automatic-insights-option
branch
from
a15c0bc to
c76dd8e
Compare
Haroenv
added a commit
that referenced
this pull request
Mar 2, 2023
FX-2250 Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Haroenv
added a commit
that referenced
this pull request
Mar 2, 2023
FX-2250 Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Haroenv
added a commit
that referenced
this pull request
Mar 8, 2023
FX-2250 Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Haroenv
added a commit
that referenced
this pull request
Apr 18, 2023
FX-2250 Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Haroenv
added a commit
that referenced
this pull request
Apr 24, 2023
FX-2250 Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of passing your own middleware, where timing could be tricky, to disable the internal middleware you pass
insights: falseto InstantSearch. Note that the internal middleware will still be removed when a different middleware is passed to allow easy customisationFX-2250