-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more searchBox work #27
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
6ef0b0b
fix: allow adding css classes to the searchBox wrapper
5f3329d
fix: rename BEM root algolia-magic to as
9309a4c
fix: reduce the dependency between REACT components and helper
6c49e18
fix: widgets.searchbox => widgets.searchBox
6826bd6
fix: use cssClass instead of inputClass or addClass
3ef55a3
fix: folder requires uses a trailing / to ease recognition of /index.js
6c75a05
docs: add sample searchBox doc
88a9c80
docs: typo
84f325d
docs: make it obvious some params are optional
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
'use strict'; | ||
|
||
var React = require('react'); | ||
|
||
var utils = require('../../lib/widgetUtils'); | ||
var bind = require('lodash/function/bind'); | ||
|
||
function searchbox(params) { | ||
var SearchBox = require('../../components/SearchBox'); | ||
var container = utils.getContainerNode(params.container); | ||
|
||
return { | ||
init: function(initialState, helper) { | ||
React.render( | ||
<SearchBox | ||
setQuery={bind(helper.setQuery, helper)} | ||
search={bind(helper.search, helper)} | ||
placeholder={params.placeholder} | ||
inputClass={params.cssClass} />, container | ||
); | ||
} | ||
}; | ||
} | ||
|
||
module.exports = searchbox; |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I removed onFocus without any specific commit. This was done to clean the widget API before we decide we do need an onFocus prop and expose it in the widget.