fix(core): make sure instance.dispose sets started flag #3399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can not immediately cause any bugs; but in Vue InstantSearch we were manually calling `render` before `init` gets called. Since `render` itself (obviously) assumes the search is already done, it uses helper functions of past-search. This fix prevents such a situation, since `started` would be false as long as the next search has not yet been done see also algolia/vue-instantsearch#607
|
Deploy preview for instantsearchjs ready! Built with commit b3c6674 |
samouss
approved these changes
Jan 18, 2019
francoischalifour
approved these changes
Jan 18, 2019
Haroenv
added a commit
that referenced
this pull request
Jan 21, 2019
Without this change, if you dispose an instance and start it again, a search (not necessarily a request, since the cache isn't cleared) should be done again with a fresh state, and not the state of before the dispose similar to #3399
francoischalifour
pushed a commit
that referenced
this pull request
Jan 23, 2019
Without this change, if you dispose an instance and start it again, a search (not necessarily a request, since the cache isn't cleared) should be done again with a fresh state, and not the state of before the dispose similar to #3399
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can not immediately cause any bugs; but in Vue InstantSearch we were manually calling
renderbeforeinitgets called. Sincerenderitself (obviously) assumes the search is already done, it uses helper functions of past-search.This fix prevents such a situation, since
startedwould be false as long as the next search has not yet been donesee also algolia/vue-instantsearch#607