Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(searchbox): remove needless snapshot #4005

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jul 31, 2019

This removes a snapshot with an inline assertion, since it's very small, and avoids the indirection. In the future if we don't want to write an assertion, I'd suggest the following flow:

  1. add toMatchInlineSnapshot
  2. change snapshot to real assertion
  3. profit

@Haroenv Haroenv force-pushed the chore/test-searchbox-snapshot branch from 35c18d0 to 1010aeb Compare August 7, 2019 09:14
@Haroenv Haroenv marked this pull request as ready for review August 7, 2019 09:14
@Haroenv Haroenv requested a review from a team August 7, 2019 09:14
@ghost ghost requested review from eunjae-lee and yannickcr and removed request for a team August 7, 2019 09:15
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Meaningless toMatchSnapshot() ruins test cases.

@Haroenv Haroenv merged commit 6b46963 into next Aug 7, 2019
@Haroenv Haroenv deleted the chore/test-searchbox-snapshot branch August 7, 2019 09:21
Haroenv added a commit that referenced this pull request Oct 23, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants