Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(index): remove unnecessary page UI state reset branch #4433

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

francoischalifour
Copy link
Member

In #4359, we introduced an unnecessary code branch that never gets executed (and is not covered by any tests).

We reset the page localUiState but then reassign the whole localUiState.

@francoischalifour francoischalifour requested a review from a team June 12, 2020 12:54
@ghost ghost requested review from eunjae-lee and Haroenv and removed request for a team June 12, 2020 12:54
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4ea4006:

Sandbox Source
InstantSearch.js Configuration

Haroenv
Haroenv previously approved these changes Jun 12, 2020
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't needed when relying on _uiState alone indeed :)

@Haroenv Haroenv dismissed their stale review June 12, 2020 13:14

e2e tests are failing because of this?

@francoischalifour
Copy link
Member Author

@Haroenv Nope, that's because they're flaky. I reran them.

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me then :)

@francoischalifour francoischalifour merged commit ea6581b into master Jun 12, 2020
@francoischalifour francoischalifour deleted the refactor/remove-ui-state-page-code-branch branch June 12, 2020 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants