chore(version): bump algoliasearch version to v4.11.0 #4939
Conversation
* refactor(version): bump algoliasearch version to v0.11.0 * Import algoliasearch tarball package with type fix * refactor(packages): Remove algoliasearch tarball * refactor(types): Remove type work-arround for boundingBox (#2) * Import algoliasearch client with type fix * Remove unecessary type enforcement * refactor(package): Bump algoliasearch to v0.11.0 fixes: #4916
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c7a1542:
|
|
@bidoubiwa, as we don't want CI errors with v3 of algoliasearch, I think this just bumping v4 wasn't enough to be able to remove the ts-expect-error, and they likely need to become ts-ignore instead now. In a next major version we can support TS only for v4, but at the moment we don't really enforce the major version. WDYT? Do you have a solution in mind? |
|
Hey @Haroenv this raised very interesting questions on which one to use between ts-ignore and ts-expect-error. I'm still not sure how this impacts the code. I reversed some changes here: #4941 |
francoischalifour
changed the title
* docs(contributing): Add doc on instantsearch cross version testing * fix(tests): Fixes insideboundingbox tests * core(geo): Reverse removal of geo forced typecasting * Update testing script in contributing * Typescript installation documentation
| V4 uses the types provided by both `algoliasearch` and `@algolia/client-search`. | ||
|
|
||
| ```bash | ||
| yarn add algoliasearch@4 @algolia/client-search |
There was a problem hiding this comment.
| yarn add algoliasearch@4 @algolia/client-search | |
| yarn add algoliasearch@4 && yarn add @algolia/client-search -D |
There was a problem hiding this comment.
why dev dependency for that one? it's a "peer" (actually usually you won't need to rely on it manually as it's a dependency of algoliasearch), but a normal dependency would be fine imo
There was a problem hiding this comment.
I usually keep all non-runtime dependencies as dev dependencies. Not a blocker in front-end anyway, people can choose how they prefer.
Feel free to ignore.
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
refactor(version): bump algoliasearch version to v0.11.0
Import algoliasearch tarball package with type fix
refactor(packages): Remove algoliasearch tarball
refactor(types): Remove type work-arround for boundingBox
Import algoliasearch client with type fix
Remove unecessary type enforcement
refactor(package): Bump algoliasearch to v0.11.0
fixes: #4916
testing the CI of #4938