fix(HitsPerPage): compute selected from isRefined #5469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it responsive to the URL, as expected like other widgets. fixes #5397 Slight improvement in the HitsPerPage + SortBy tests, as it was relying on Vue state instead of the DOM I wanted both to be exactly the same, but SortBy doesn't have isRefined on the items apparently.
Haroenv
requested review from
a team,
FabienMotte and
sarahdayan
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e0ebf9c:
|
sarahdayan
approved these changes
Feb 1, 2023
|
Yes, I doubted to write a common test here, but I was juggling too many other things to write it just yet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #5397
Slight improvement in the HitsPerPage + SortBy tests, as it was relying on Vue state instead of the DOM
I wanted both to be exactly the same, but SortBy doesn't have isRefined on the items apparently.
Workaround in the example to make HitsPerPage responsive to the URL is also removed.
Result
This makes HitsPerPage responsive to the URL, as expected like other widgets.