fix(rangeinput): allow input of numbers with precision #5541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While we set the `step` correctly based on the precision, we didn't actually allow input of values with decimal separator because the "inbetween" situation (like 1.) isn't a valid number, causing the state to reset. To solve this, we prevent saving the value to react state if the value is invalid. The browser will take over from there and show warnings if it's not a number. CR-2948
Haroenv
requested review from
aymeric-giraudet,
a team and
dhayab
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 10dc88a:
|
aymeric-giraudet
previously approved these changes
Mar 14, 2023
dhayab
reviewed
Mar 14, 2023
packages/instantsearch.js/src/components/RangeInput/RangeInput.tsx
Outdated
Show resolved
Hide resolved
# Conflicts: # packages/instantsearch.js/src/__tests__/common.test.tsx # packages/react-instantsearch-hooks-web/src/__tests__/common.test.tsx # packages/vue-instantsearch/src/__tests__/common.test.js # tests/common/index.ts
Closed
aymeric-giraudet
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
While we set the
stepcorrectly based on the precision, we didn't actually allow input of values with decimal separator because the "inbetween" situation (like 1.) isn't a valid number, causing the state to reset.Vue didn't have this issue, as it wasn't parsing the number until the form is being submitted.
CR-2948
FX-2274
Result
To solve this, we keep the values as a
stringin the state, we cast them asnumberwhen werefine().Dot decimal separator is working as expected, comma is not supported as before.