fix(searchbox): add aria-hidden to svg icons

[pat-sullivan]

Summary
Added aria-hidden="true" attributes to the following SVG icons used in the repo:

• ais-SearchBox-resetIcon
• ais-SearchBox-loadingIcon
• ais-SearchBox-submitIcon

This is in response to a Shopify customer support ticket saying these icons were flagged (for missing title attributes) during an accessibility audit. Since these icons are nested below buttons with title attributes, an aria-hidden attribute seemed the better option.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ee46988:

Sandbox	Source
InstantSearch.js	Configuration
react-instantsearch-app	Configuration
example-react-instantsearch-hooks-default-theme	Configuration
example-vue-instantsearch-default-theme	Configuration

[Haroenv]

Thanks @pat-sullivan, this looks like a great start! we should indeed have these images aria-hidden, as they are purely visual and have a parent with a title

[Haroenv]

these Vue snapshots need aria-hidden as the first property (it's alphabetically sorted)

[pat-sullivan]

@Haroenv Thanks for pointing that out! I've made the necessary adjustments. However I can't seem to get past that flaky unit test on packages/react-instantsearch-hooks-server/src/__tests__/modules-none.test.tsx

[Haroenv]

thanks! This looks good to me