feat(hits/infinite-hits): send a default click event and expose sendEvent to slot #5549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
requested review from
a team,
dhayab and
aymeric-giraudet
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f111d51:
|
Haroenv
force-pushed
the
feat/vue-default-click
branch
from
1a6a54f to
a2f8aa9
Compare
Haroenv
commented
Mar 15, 2023
dhayab
approved these changes
Mar 16, 2023
Base automatically changed from
fix/prevent-dupe-events-click
to
feat/automatic-insights
March 16, 2023 09:10
…vent to slot it's like FX-2271, but for Vue
- scopedSlots -> children - on.method -> onMethod
Haroenv
force-pushed
the
feat/vue-default-click
branch
from
a2f8aa9 to
f111d51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's like FX-2271, but for Vue.
I recommend you review this PR with "ignore whitespace" enabled, it's quite confusing otherwise