Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release #5845

Merged
merged 4 commits into from
Sep 13, 2023
Merged

chore: release #5845

merged 4 commits into from
Sep 13, 2023

Conversation

dhayab
Copy link
Member

@dhayab dhayab commented Sep 12, 2023

This pull request prepares the following release:

Repository Branch Update
instantsearch chore/release-1694529882358 minor

Release Summary

This is going to be published with the following command:

yarn lerna publish from-package --yes

Merging Instructions

When merging this pull request, you need to Squash and merge and make sure that the title starts with chore: release.

See details

After that, a commit chore: release will be added and you or your CI can run shipjs trigger to trigger the release based on the commit.
Squash and merge


This pull request is automatically generated by Ship.js.

@dhayab dhayab requested review from a team, sarahdayan and aymeric-giraudet and removed request for a team September 12, 2023 14:44
@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 12, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 13addfa:

Sandbox Source
InstantSearch.js Configuration
react-instantsearch-app Configuration
example-react-instantsearch-default-theme Configuration
example-vue-instantsearch-default-theme Configuration

Copy link
Member Author

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some whitespace correction due to shipjs working on top of linted files from last PR, and 2 packages have version bumps when they shouldn't (see below).

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (although possibly a couple internal-only changes trigger a release. Fine for me

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added the insights PR #5848

@dhayab dhayab requested a review from Haroenv September 13, 2023 09:39
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (if you don't mind that we'll solve the vue templates later)

@dhayab dhayab merged commit 046ba8a into master Sep 13, 2023
@dhayab dhayab deleted the chore/release-1694529882358 branch September 13, 2023 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants