Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue-instantsearch): only render list in <refinement-list> when it has items #6092

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix(vue-instantsearch): only render list in <refinement-list> when it has items #6092

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vue-instantsearch/src/components/RefinementList.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
>
<div :class="suit('noResults')">No results.</div>
</slot>
<ul :class="suit('list')">
<ul v-if="items.length > 0" :class="suit('list')">
<li
:class="[suit('item'), item.isRefined && suit('item', 'selected')]"
v-for="item in items"
Expand Down
2 changes: 0 additions & 2 deletions packages/vue-instantsearch/src/components/__tests__/__snapshots__/RefinementList.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,6 @@ exports[`allows search bar classes override when it's searchable 1`] = `

exports[`renders correctly (empty) 1`] = `
<div class="ais-RefinementList ais-RefinementList--noRefinement">
<ul class="ais-RefinementList-list">
</ul>
</div>
`;

Expand Down