chore: types running with v4 locally, but also v4 and v3 #6271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doesn't work as there still are v4 v5 differences of course
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit fa45bd4:
|
will be fixed once algolia/api-clients-automation#3357 is done
Haroenv
changed the title
Haroenv
commented
Jul 15, 2024
Comment on lines
+132
to
+134
| // v5 expects only string values for facetName and facetValue | ||
| facetName: undefined as unknown as string, | ||
| facetValue: undefined as unknown as string, |
There was a problem hiding this comment.
algolia/api-clients-automation#3355 after this is released we can amend to remove the cast. Still find for now as it's just a test though
| @@ -31,7 +29,7 @@ export type FrequentlyBoughtTogetherRenderState< | |||
| /** | |||
| * The matched recommendations from Algolia API. | |||
| */ | |||
| items: Array<Hit<THit>>; | |||
| items: Array<AlgoliaHit<THit>>; | |||
There was a problem hiding this comment.
all recommend changes Hit -> AlgoliaHit is because __position and __queryId aren't actually present in these connectors
dhayab
approved these changes
Jul 15, 2024
Haroenv
added a commit
that referenced
this pull request
Jul 17, 2024
* chore: change type * WIP: expand search parameters doesn't work as there still are v4 v5 differences of course * do it correctly * use regular client * not sure if this should stay * WIP * changes rule * fix dependency * change order to make script work * almost all types fixed * improve test * fix(types): accepts client with wrong types will be fixed once algolia/api-clients-automation#3357 is done * tests * chore(helper): compatibility * chore(legacy): correct replacement * don't remove v5 fully * fix errors * safer (or less safe lol) * correct import * fix fake type * v5 only works * tests * script for examples too * script for examples too * chore(answers): bleh get rid of this! * stuff * simplify
Haroenv
added a commit
that referenced
this pull request
Aug 19, 2024
* chore: change type * WIP: expand search parameters doesn't work as there still are v4 v5 differences of course * do it correctly * use regular client * not sure if this should stay * WIP * changes rule * fix dependency * change order to make script work * almost all types fixed * improve test * fix(types): accepts client with wrong types will be fixed once algolia/api-clients-automation#3357 is done * tests * chore(helper): compatibility * chore(legacy): correct replacement * don't remove v5 fully * fix errors * safer (or less safe lol) * correct import * fix fake type * v5 only works * tests * script for examples too * script for examples too * chore(answers): bleh get rid of this! * stuff * simplify
Haroenv
added a commit
that referenced
this pull request
Aug 20, 2024
* chore(examples): update search client to v5 * chore: types running with v4 locally, but also v4 and v3 (#6271) * chore: change type * WIP: expand search parameters doesn't work as there still are v4 v5 differences of course * do it correctly * use regular client * not sure if this should stay * WIP * changes rule * fix dependency * change order to make script work * almost all types fixed * improve test * fix(types): accepts client with wrong types will be fixed once algolia/api-clients-automation#3357 is done * tests * chore(helper): compatibility * chore(legacy): correct replacement * don't remove v5 fully * fix errors * safer (or less safe lol) * correct import * fix fake type * v5 only works * tests * script for examples too * script for examples too * chore(answers): bleh get rid of this! * stuff * simplify * ci: add downgrade script for algoliasearch v4 and steps (#6286) * ci: add downgrade script for algoliasearch v4 and steps * test:ci instead * store results * fixes --------- Co-authored-by: Haroen Viaene <hello@haroen.me> Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Result
all tests green