Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hits): add banners to Hits widget for Vue #6276

Merged
merged 13 commits into from
Jul 16, 2024
Merged

feat(hits): add banners to Hits widget for Vue #6276

merged 13 commits into from
Jul 16, 2024

Conversation

taylorcjohnson
Copy link
Contributor

@taylorcjohnson taylorcjohnson commented Jul 9, 2024 •
edited
Loading

Summary

This PR adds the new top banner to the Vue Hits widget and updates associated tests. The top banner feature has already been added to Hits and InfiniteHits for the JS and React flavors of InstantSearch.

This widget is slightly different from the React version by using a showBanner prop (defaulted to true) since the already updated InfiniteHits Vue widget uses this approach.

Jira issue

Result

Getting Started example app:image

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Jul 9, 2024 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 940b40e:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@taylorcjohnson taylorcjohnson changed the title wip(hits): pass banner data to createHitsComponent() feat(hits): add banners to Hits widget for Vue Jul 12, 2024
@taylorcjohnson taylorcjohnson self-assigned this Jul 12, 2024
@taylorcjohnson taylorcjohnson requested review from a team, Haroenv and aymeric-giraudet and removed request for a team July 12, 2024 18:23
@taylorcjohnson taylorcjohnson marked this pull request as ready for review July 12, 2024 18:23
@aymeric-giraudet aymeric-giraudet merged commit eb95049 into master Jul 16, 2024
12 checks passed
@aymeric-giraudet aymeric-giraudet deleted the feat/hits/add-banners-to-vue branch July 16, 2024 10:20
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Jul 16, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Jul 16, 2024
Open
@YoYBaBy YoYBaBy mentioned this pull request Jul 17, 2024
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Jul 23, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Jul 23, 2024
Open
This was referenced Jul 24, 2024
Open
Open
Open
This was referenced Jul 25, 2024
Open
Open
@YoYBaBy YoYBaBy mentioned this pull request Jul 27, 2024
Open
@satoshinakamoto007 satoshinakamoto007 mentioned this pull request Jul 30, 2024
Open
@ashly1111111 ashly1111111 mentioned this pull request Jul 30, 2024
Open
This was referenced Jul 31, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymeric-giraudet aymeric-giraudet aymeric-giraudet approved these changes

@Haroenv Haroenv Haroenv approved these changes

Assignees

@taylorcjohnson taylorcjohnson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@taylorcjohnson @Haroenv @aymeric-giraudet