-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instantsearch.js): introduce carousel
template
#6314
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 77f0549:
|
3e50729
to
205eb93
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
data={{ | ||
items: data.items, | ||
templates: { | ||
item: templates.item |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
surely there's always at least a default item template?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default item template is defined in the UI component. At the widget level, the itemComponent
can be undefined, which will be forwarded as-is to the UI component and be defaulted there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! We can probably update trendingItems()
the js getting-started example to use the carousel layout. We can also wait until we release instantsearch.css (we load themes from a CDN in the examples).
This introduces the
carousel
template and implements thelayout
template in Recommend widgets.https://algolia.atlassian.net/browse/FX-2818