Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instantsearch.js): introduce carousel template #6314

Merged
merged 11 commits into from
Aug 7, 2024

Conversation

sarahdayan
Copy link
Member

@sarahdayan sarahdayan commented Aug 6, 2024

This introduces the carousel template and implements the layout template in Recommend widgets.

https://algolia.atlassian.net/browse/FX-2818

Copy link

codesandbox-ci bot commented Aug 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 77f0549:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

@sarahdayan sarahdayan marked this pull request as ready for review August 6, 2024 15:27
@sarahdayan sarahdayan requested review from dhayab and Haroenv August 6, 2024 15:36
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

data={{
items: data.items,
templates: {
item: templates.item
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

surely there's always at least a default item template?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default item template is defined in the UI component. At the widget level, the itemComponent can be undefined, which will be forwarded as-is to the UI component and be defaulted there.

@sarahdayan sarahdayan requested a review from Haroenv August 7, 2024 08:58
Copy link
Member

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! We can probably update trendingItems() the js getting-started example to use the carousel layout. We can also wait until we release instantsearch.css (we load themes from a CDN in the examples).

@sarahdayan sarahdayan merged commit b40f2a9 into master Aug 7, 2024
12 checks passed
@sarahdayan sarahdayan deleted the feat/is-carousel branch August 7, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants