-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-instantsearch): add Carousel
layout component
#6320
Closed
Closed
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
122e683
feat(react-instantsearch) create carousel component
shaejaz 7aecbe8
feat(react-instantsearch) add layout to recommend components
shaejaz d070f62
test(react-instantsearch) add tests for carousel
shaejaz 509c2c1
test(react-instantsearch) test layout for recommend components
shaejaz c8df40f
chor(react-instantsearch) expose templates
shaejaz e94719a
docs(react-instantsearch) update getting started example with carousel
shaejaz c651c7c
fix(react-instantsearch) fix example styles
shaejaz 6aa1826
fix(react-instantsearch) fix example import
shaejaz 1081643
fix typo
shaejaz ee03d05
fix: remove redundant jsx in examples
shaejaz cc33670
fix: fix layout translation types
shaejaz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
export * from 'react-instantsearch-core'; | ||
export * from './widgets'; | ||
export * from './templates'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
import { | ||
createCarouselComponent, | ||
generateCarouselId, | ||
} from 'instantsearch-ui-components'; | ||
import React, { createElement, Fragment, useRef } from 'react'; | ||
|
||
import type { | ||
CarouselProps as CarouselUiProps, | ||
Pragma, | ||
} from 'instantsearch-ui-components'; | ||
|
||
const CarouselUiComponent = createCarouselComponent({ | ||
createElement: createElement as Pragma, | ||
Fragment, | ||
}); | ||
|
||
export type CarouselProps<TObject extends Record<string, unknown>> = Omit< | ||
CarouselUiProps<TObject>, | ||
'listRef' | 'nextButtonRef' | 'previousButtonRef' | 'carouselIdRef' | ||
>; | ||
|
||
export function Carousel<TObject extends Record<string, unknown>>( | ||
props: CarouselProps<TObject> | ||
) { | ||
const carouselRefs: Pick< | ||
CarouselUiProps<TObject>, | ||
'listRef' | 'nextButtonRef' | 'previousButtonRef' | 'carouselIdRef' | ||
> = { | ||
listRef: useRef(null), | ||
nextButtonRef: useRef(null), | ||
previousButtonRef: useRef(null), | ||
carouselIdRef: useRef(generateCarouselId()), | ||
}; | ||
|
||
return <CarouselUiComponent {...carouselRefs} {...props} />; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this folder be
components
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. In
instantsearch.js
it's intemplates
although that is stated in the RFC (which is not the case for the React counterpart). Let me know ifcomponents
is better for React!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with @Haroenv, we have different APIs in InstantSearch.js (
templates
object) and React InstantSearch (individual component props) for customizing the UI so it makes sense to have different names.