-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(config): update jsDelivrHitsEndpoint url #1074
Conversation
This change also makes the memory footprint of the response about 20x smaller by excluding packages with very few hits (< 100 / month) on the server, as they are being filtered out here anyway. |
Ping 😄 |
Sorry, I lost access to merge on this repository and haven't yet received a response from security. Will update |
Ok I have access again 🙌 Should this PR still be merged now @MartinKolarik ? |
Yes please, we still need to migrate this in two steps as described above. |
@MartinKolarik it looks like the test fails and jsDelivrHits is significantly lower than expected for some packages. Do you think that's expected? |
Hmm what tests exactly? |
Oh, I see. That's the number of packages in the response. That's affected by this:
So yes, it's expected the number is much lower now, I didn't realize there was a test for it. |
Thanks, I've updated it in d99c31f |
## [1.7.14](v1.7.13...v1.7.14) (2022-12-07) ### Bug Fixes * **config:** update jsDelivrHitsEndpoint url ([#1074](#1074)) ([6213f95](6213f95))
The current URL uses an undocumented feature we'll have to remove soon due to path conflicts with some new endpoints. To avoid any disruption here, this PR switches to a new URL on our preview environment.
Once we ship all changes to the production env (and this new endpoint is added and the old one removed), I'll send another PR to switch from
data-jsdelivr-com-preview.onrender.com
todata.jsdelivr.com