refactor(main): write the main control flow in an async function #129
Conversation
|
conflict now |
|
conflict fixed. |
There was a problem hiding this comment.
Now that we have good settings handling, could you update the code to do a setSettings when bootstrap data is moved to production?
Settings must be set:
- beginning of the script (like you did), usecase: we update settings on a running instance
- end of bootstrap phase (after moveToProduction), usecase: handle copyIndex settings erase
No more needed to copy settings from production to bootstrap index now that all settings are in the code.
WDYT?
Also we need to check the memory consumption of the current code before deploying this fix. I have no idea of memory implication of doing this await code versus chained promises (in one case you have a big scope, in another you have one scope per task)
src/index.js
Outdated
| .catch(error); | ||
| async function main() { | ||
| await setSettings(mainIndex); | ||
| await setSettings(bootstrapIndex); |
There was a problem hiding this comment.
Why setSettings on the bootstrap index?
|
Makes sense! I'll change it to what you suggested |
|
I set the settings on the bootstrap index as well so that if you use the search in the bootstrap phase, it will be set up correctly, and as a real follower (for quick QA) |
|
Unsure about what's needed here? |
|
I never investigated what the memory impact is (see your comment about scope). Probably still gonna quickly refactor to be the new logic and merge next week |
Haroenv
force-pushed
the
refactor/main-function
branch
from
44825b1
to
8c3641c
Compare
Not necessary, but found this easier to read
depends on #128