fix(quotes): fixes #82 #81 #80

algolia · Jun 7, 2017 · 3d96ddc · 3d96ddc
1 parent 5c0ae3e
commit 3d96ddc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/index-test.js b/index-test.js
@@ -70,18 +70,18 @@ describe('reactElementToJSXString(ReactElement)', () => {
       reactElementToJSXString(
         React.createElement('div', { title: "<'hello' you & you>" })
       )
-    ).toEqual('<div title="&lt;&#39;hello&#39; you &amp; you&gt;" />');
+    ).toEqual('<div title="<\'hello\' you & you>" />');
   });
 
   it("reactElementToJSXString(<div obj={{ nested: <div arr={['hello', 'you']} /> }} />)", () => {
     expect(
       reactElementToJSXString(
-        <div obj={{ nested: <div arr={['hello', 'you']} /> }} />
+        <div obj={{ nested: <div arr={['hello', 'you']}>Hello "' you</div> }} />
       )
     ).toEqual(
       `<div
   obj={{
-    nested: <div arr={['hello', 'you']} />
+    nested: <div arr={['hello', 'you']}>Hello "' you</div>
   }}
  />`
     );

diff --git a/index.js b/index.js
@@ -5,8 +5,9 @@ import isPlainObject from 'is-plain-object';
 import stringify from 'stringify-object';
 import sortobject from 'sortobject';
 import traverse from 'traverse';
-import { fill, escape } from 'lodash';
+import { fill } from 'lodash';
 
+const escape = s => s.replace(/"/g, '&quot;');
 const defaultFunctionValue = fn => fn;
 
 export default function reactElementToJSXString(