Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update react peerDependencies for React 18 #728

Closed
markhughes opened this issue May 3, 2022 · 5 comments
Closed

Update react peerDependencies for React 18 #728

markhughes opened this issue May 3, 2022 · 5 comments

Comments

@markhughes
Copy link
Contributor

Could we update the peerDependencies to allow React 18?

  "peerDependencies": {
--    "react": "^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1",
++    "react": "^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1 || ^18.0.0",
--    "react-dom": "^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1"
++    "react-dom": "^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1  || ^18.0.0"
  },
@daelynj
Copy link

daelynj commented May 3, 2022

I am also hoping for this change.

@jttry
Copy link

jttry commented May 7, 2022

I am also hoping for this change.

+1

@armandabric
Copy link
Collaborator

armandabric commented May 9, 2022

I'm also for this change but me OSS time have vanish theses last months. I will be happy to review a PR for this.

markhughes added a commit to markhughes/react-element-to-jsx-string that referenced this issue May 9, 2022
@markhughes
Copy link
Contributor Author

markhughes commented May 9, 2022

Hey @armandabric I've put together the change and even added smoke tests (works fine): #729

thanks for the idea!

@armandabric
Copy link
Collaborator

armandabric commented May 9, 2022

🚀 The support of React 18 is release in v15.0.0. Please give feedback if you have issue with it. Thanks for @markhughes for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants