-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(browser): Add IE 11 support #288
Conversation
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
1 similar comment
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
The glob pattern doesn't seem to work. It's transpiling everything in Does anyone have tips on how to make it only exclude |
maybe @pascalduez knows and can help here? |
@danoc What you could do is use include instead of exclude or mix them? Might be easier than trying to find the right glob pattern |
exclude: 'node_modules/!(stringify-object)/**' |
Great, that worked well. Here's a diff of the CJS output: https://www.diffchecker.com/RPnK1ARg Notice that only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this fix! I miss it in my previous PR.
Thanks @Spy-Seth! @vvo — I think this one is good to go! |
This adds IE 11 support as well as support for older versions of Uglify.
It does so by transpiling
stringify-object
with babel.Closes #211, #285