Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

Start testing React 16 #215

Closed
vvo opened this issue Jul 27, 2017 · 7 comments
Closed

Start testing React 16 #215

vvo opened this issue Jul 27, 2017 · 7 comments

Comments

@vvo
Copy link
Contributor

vvo commented Jul 27, 2017

It's out! facebook/react#10294

There will be soon a way to activate async rendering too (No idea what that means).

The sooner we try it the better usually for this kind of dependency.

Last time for React 15 we did not do it while we discovered breaking changes in React 15 (once released). See algolia/react-element-to-jsx-string#56 (comment)

@Haroenv
Copy link
Contributor

Haroenv commented Jul 27, 2017

see #212 and #211

@mthuret
Copy link
Contributor

mthuret commented Jul 27, 2017

I'm currently in the process to write tests for all our recipes. We'll merge those PR afterwards (only concerns react-native example).

And yes, we should tried the beta on all the rest of the code.

@mthuret
Copy link
Contributor

mthuret commented Aug 21, 2017

Some news about the beta:

I upgraded and played with the e-commerce demo. Except one warning (defaultProps non static on List) it seems to work fine.

The storybook is completely broken though.

@mthuret
Copy link
Contributor

mthuret commented Sep 22, 2017

@mthuret
Copy link
Contributor

mthuret commented Sep 27, 2017

Step to get there:

  • Ensure that storybook is working with 16

  • Fix our Enzyme test using the new adapter strategy

@boaticus
Copy link

boaticus commented Sep 30, 2017

As mentioned, defaultProps not being static on List is still throwing this warning:

Setting defaultProps as an instance property on List is not supported and will be ignored. Instead, define defaultProps as a static property on List.

I see one of the branches in progress has this fixed, however.

@mthuret
Copy link
Contributor

mthuret commented Oct 4, 2017

@boaticus I'm in the middle of cleaning and upgrading everything :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants