Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

fix(List): remove React16 warning #442

Merged
merged 3 commits into from
Oct 9, 2017
Merged

fix(List): remove React16 warning #442

merged 3 commits into from
Oct 9, 2017

Conversation

mthuret
Copy link
Contributor

@mthuret mthuret commented Oct 9, 2017 •
edited
Loading

As I don't know how many times the switch to React16 for our tooling will last, let's release a new version of RIS that remove the List warning.

See #215

@algobot
Copy link
Contributor

algobot commented Oct 9, 2017 •
edited
Loading

Deploy preview ready!

Built with commit c27894e

https://deploy-preview-442--react-instantsearch.netlify.com

@mthuret mthuret requested a review from vvo October 9, 2017 11:27
@vvo
Copy link
Contributor

vvo commented Oct 9, 2017

As I don't know how many times the switch to React16 for our tooling will last

Do you mean that this warning is triggered by one of our tooling not yet being compatible with React 16? Which one?

@mthuret
Copy link
Contributor Author

mthuret commented Oct 9, 2017

@vvo sorry, it's the opposite. This warning is fired by our lib when used by our user. There's another PR taking care of migrating everything on React 16 (storybook, recipes, tests...) but because of some issues I can't merge it yet, that's why I'm fixing this warning separately.

vvo
vvo approved these changes Oct 9, 2017
View reviewed changes
Copy link
Contributor

@vvo vvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this still works with React 15, then LGTM

@vvo
Copy link
Contributor

vvo commented Oct 9, 2017 •
edited
Loading

Small note, we never discussed this, but do you think our codebase is still React 15 compatible? If a user is using React 15, will it work?

@mthuret
Copy link
Contributor Author

mthuret commented Oct 9, 2017

Actually this fix a bug in React 15 (defaultProps were not taken into account if not static).

@mthuret mthuret merged commit 8d6cf18 into master Oct 9, 2017
@mthuret mthuret deleted the fix/warning-react-16 branch October 9, 2017 13:47
mthuret pushed a commit that referenced this pull request Oct 9, 2017
v4.1.3
26b3d3a 
<a name="4.1.3"></a>
## [4.1.3](v4.1.2...v4.1.3) (2017-10-09)

### Bug Fixes

* **List:** remove React16 warning ([#442](#442)) ([8d6cf18](8d6cf18))

### Features

* **connectStateResults:** add component props ([#434](#434)) ([c629b97](c629b97))
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vvo vvo vvo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mthuret @algobot @vvo