Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

feat(smartSort): add widget #3009

Merged
merged 18 commits into from
Feb 22, 2021
Merged

feat(smartSort): add widget #3009

merged 18 commits into from
Feb 22, 2021

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Feb 16, 2021 •
edited
Loading

Implements smartSort widget

related: algolia/instantsearch#4648

@shortcuts shortcuts requested review from a team, yannickcr and eunjae-lee and removed request for a team February 16, 2021 14:15
@shortcuts shortcuts marked this pull request as draft February 16, 2021 14:18
@codesandbox-ci
Copy link

codesandbox-ci bot commented Feb 16, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@shortcuts @Haroenv
fix unused var TS error
375e452 
Co-authored-by: Haroen Viaene <hello@haroen.me>
@shortcuts @Haroenv
Fix isVirtualReplica boolean
f310318 
Co-authored-by: Haroen Viaene <hello@haroen.me>
@algobot
Copy link
Contributor

algobot commented Feb 16, 2021

Deploy preview for react-instantsearch ready!

Built with commit 375e452

https://deploy-preview-3009--react-instantsearch.netlify.app

@algobot
Copy link
Contributor

algobot commented Feb 16, 2021 •
edited
Loading

Deploy preview for react-instantsearch ready!

Built with commit f7eae28

https://deploy-preview-3009--react-instantsearch.netlify.app

shortcuts and others added 4 commits February 16, 2021 15:39
@shortcuts shortcuts mentioned this pull request Feb 16, 2021
Merged
Haroenv
Haroenv approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@shortcuts shortcuts marked this pull request as ready for review February 18, 2021 09:11
@shortcuts
feat(stats): apply nbSortedHits (#3010)
7773030 
* fix(stats): apply nbSortedHits
eunjae-lee
eunjae-lee approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🙌

shortcuts and others added 2 commits February 18, 2021 17:00
@shortcuts @Haroenv
Fix isSmartSorted condition
c53fb17 
Co-authored-by: Haroen Viaene <hello@haroen.me>
@shortcuts
lint
5be0a20
@shortcuts shortcuts mentioned this pull request Feb 19, 2021
Merged
7 tasks
@eunjae-lee
Copy link
Contributor

looks good to me!

@shortcuts shortcuts merged commit 4cc8412 into master Feb 22, 2021
@shortcuts shortcuts deleted the feat/smartSort branch February 22, 2021 14:21
eunjae-lee added a commit that referenced this pull request Feb 23, 2021
@eunjae-lee
v6.10.0
cd81453 
# [6.10.0](v6.9.0...v6.10.0) (2021-02-23)

### Bug Fixes

* **infiniteHits:** do not cache the cached hits ([#3011](#3011)) ([b56f5f7](b56f5f7))

### Features

* **smartSort:** add widget ([#3009](#3009)) ([4cc8412](4cc8412)), closes [#3010](#3010)
@shortcuts shortcuts mentioned this pull request Feb 25, 2021
Merged
@eunjae-lee eunjae-lee mentioned this pull request Mar 1, 2021
Merged
1 task
This was referenced Mar 15, 2021
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Haroenv Haroenv Haroenv approved these changes

@eunjae-lee eunjae-lee eunjae-lee approved these changes

@yannickcr yannickcr Awaiting requested review from yannickcr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shortcuts @algobot @eunjae-lee @Haroenv