Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add queryID & postion as a preperation for Recommend Analytics [RECO-2391] #192

Merged
merged 7 commits into from
Dec 18, 2024
Merged

feat: Add queryID & postion as a preperation for Recommend Analytics [RECO-2391] #192

merged 7 commits into from
Dec 18, 2024

Conversation

raed667
Copy link
Collaborator

@raed667 raed667 commented Dec 3, 2024 •
edited
Loading

What

In @algolia/recommend-js & @algolia/recommend-react we want to allow users to be able to send insights events.

For this to be possible we want each recommend widget to add the following data to the hits when possible:

__position?: number;
__indexName: string;
__queryID?: string;

Picking up the work done on #124 & #123

@raed667 raed667 requested a review from marialungu December 3, 2024 10:11
@raed667 raed667 requested a review from dhayab December 3, 2024 10:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024 •
edited
Loading

PR Preview Action v1.4.8
Preview removed because the pull request was closed.
2024-12-18 10:33 UTC

dhayab
dhayab approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only have a couple of nitpicky remarks, other than that it works for me 😃

packages/recommend-core/src/utils/mapToRecommendations.ts Show resolved Hide resolved
packages/recommend-core/src/getBatchRecommendations.ts Show resolved Hide resolved
@raed667 raed667 changed the title feat: Add queryID & postion as a preperation for Recommend Analytics feat: Add queryID & postion as a preperation for Recommend Analytics [RECO-2391] Dec 3, 2024
@raed667 raed667 marked this pull request as ready for review December 3, 2024 13:25
marialungu
marialungu approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@marialungu marialungu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@raed667 raed667 merged commit c5e44de into next Dec 18, 2024
7 checks passed
@raed667 raed667 deleted the feat/analytics/return-query-id branch December 18, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhayab dhayab dhayab approved these changes

@marialungu marialungu marialungu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@raed667 @dhayab @marialungu