Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: upgrade playwright and deps #879

Merged
merged 7 commits into from
Sep 6, 2024
Merged

fix: upgrade playwright and deps #879

merged 7 commits into from
Sep 6, 2024

Conversation

dylantientcheu
Copy link
Contributor

In this PR:
A little housekeeping and improvements:

  • update Playwright to its latest version - will help improve performance and use latest browsers updates
  • update Express to its latest minor
  • Add a few more flags to the browser's launch to help optimize javascript rendering (search on this list for what they can do) LMK if you prefer in depth explanation on why I think the flags would work.

sbellone
sbellone previously approved these changes Jun 17, 2024
View reviewed changes
Copy link
Collaborator

@sbellone sbellone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for handling that 💪

8bittitan
8bittitan previously approved these changes Jun 26, 2024
View reviewed changes
@dylantientcheu dylantientcheu dismissed stale reviews from 8bittitan and sbellone via 31cf095 July 16, 2024 14:36
@dylantientcheu dylantientcheu mentioned this pull request Jul 17, 2024
Open
NatanTechofNY
NatanTechofNY approved these changes Sep 6, 2024
View reviewed changes
Copy link

@NatanTechofNY NatanTechofNY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can we make sure this is fully tested and working before merged?

@dylantientcheu dylantientcheu merged commit 0ab0095 into master Sep 6, 2024
2 checks passed
algolia-bot added a commit that referenced this pull request Sep 6, 2024
@algolia-bot
chore(release): 2.2.17 [skip ci]
93a7f5c 
## [2.2.17](v2.2.16...v2.2.17) (2024-09-06)

### Bug Fixes

* upgrade playwright and deps ([#879](#879)) ([0ab0095](0ab0095))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@8bittitan 8bittitan 8bittitan approved these changes

@NatanTechofNY NatanTechofNY NatanTechofNY approved these changes

@sbellone sbellone sbellone left review comments

Assignees

@sbellone sbellone

@clemfromspace clemfromspace

@dylantientcheu dylantientcheu

@8bittitan 8bittitan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dylantientcheu @sbellone @NatanTechofNY @8bittitan @clemfromspace