Add LocalSettingsRepositoryContract #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebastiandedeyne
force-pushed
the
feat/local-settings-repository-contract
branch
from
50a5d3a
to
4094fb2
Compare
|
Tests are failing but I don't think that's related to this PR. |
DevinCodes
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
Thank you for the PR @sebastiandedeyne !
The tests were not failing because of your code indeed, there's an issue with one of the projects we're using to generate credentials. Sorry for the inconvenience.
|
Just released this in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
We're working on a multi-tenant app and would like more fine-grained control over how config is stored. Since
LocalSettingsRepositoryisfinal, we're not able to extend it to modify (see #222 for a previous attempt to make it extendable).I respect the decision to keep everything
final, so instead I propose creating a contract for theLocalSettingsRepository, so package users may bind their own implementation to the IoC.What problem is this fixing?
Provides more control over local configuration storage, useful when dealing with multiple environments (see #123) or multi-tenant applications.