-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: circumvent queue when using aggregators #287
Conversation
@damcou Could you review this PR when you have some spare time, please? 😄 |
On Monday we are going to pull this fix into our production environment and run it for a couple of days and see how it copes. Will report back if this hasn't been merged by then 👍 |
We now have this PR running in our production environment. Initial tests show that everything is running great, but we are going to leave it a few days and report back 👍🏻 |
Been running this code now for 5 days with no reported issues. I'd say it is good to go 👍🏻 |
That's awesome, thank you for reporting back @JayBizzle ! I'll reach out to @damcou for PR approval so we can release this this week 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops sorry, I missed the first ping apparently.
Looks good to me 🚀
55f7138
to
3e21d03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@JayBizzle This is available in v2.0.2 which was just released! I'm releasing a patch for v1 in a bit (see #303) |
Brilliant, thank you 👍🏻 |
Error again with 2.0.2 : Model not defined in aggregator. if ($this->model === null) { Controller: Product::find($id)->delete(); |
@jackdaniel9 likely related to #305 |
Describe your change
This PR adds a change to circumvent the queue when using aggregators.
What problem is this fixing?
See #282