Add lazyMap method to Algolia engine
#307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevinCodes
approved these changes
Jun 13, 2022
|
Hi again @bakerkretzmar ! We've just released v2.0.3, which include this fix as well as the contribution you made in #308 . Thank you for contributing 💙 |
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
Adds a
lazyMapmethod to the Algolia engine to fix #298. This PR is a band-aid solution—it doesn't actually implement any 'lazy' functionality the way Scout does,lazyMapbehaves exactly the same asmapand just returns a lazy collection, but at least nowlazyMapwill work instead of returning no results.What problem is this fixing?
See #298.
lazyMapis not currently implemented, and because Scout Extended uses different result keys than Scout does, callinglazyMapwhen using Scout Extended always returns no results.cc @DevinCodes