-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for scoped packages #451
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jeetiss, thanks for coming up with this PR :)
I've checked the NPM documentation, and found this
[--access <public|restricted>] Tells the registry whether this package should be published as public or restricted. Only applies to scoped packages, which default to restricted. If you don’t have a paid account, you must publish with --access public to publish scoped packages.
I guess un-scoped packages are always published in public. --access
should be a thing for only scoped packages.
If I understand correctly, the xor
part can be simplified, checking only if it's a scoped package.
What do you think?
Yes, @eunjae-lee you right I'm missed that access flag applies only to scoped packages |
@jeetiss That way, the publishCommand function is being quoted. |
re #436
isScopedPackage
verification on setup steppublishCommand
to config, based on information from previous stepPS: I added restricted access except scoped package support, if somebody with default package (not scoped) chose don't publish public package. Setup script will add custom
publishCommand
with--access restricted
🤖