Skip to content
This repository has been archived by the owner on Dec 30, 2022. It is now read-only.

Feature: pass in the page when emitting the page change event #393

Closed
VinceG opened this issue Feb 14, 2018 · 2 comments · Fixed by #394
Closed

Feature: pass in the page when emitting the page change event #393

VinceG opened this issue Feb 14, 2018 · 2 comments · Fixed by #394

Comments

@VinceG
Copy link
Contributor

VinceG commented Feb 14, 2018

Feature: What is your use case for such a feature?

Right now when the page change event is emitted it's empty. it'll be nice to get the page it was changed to passed in.

This might not be an actual feature or a bug but rather a minor change. I can submit a PR if needed. I was also wondering if there is a way to access the current page in any other way?

Edit: I guess the page can be accessed with the following code:

this.$refs.search._localSearchStore.page

However the page being passed as part of the event is helpful.

Thank You.

@Haroenv
Copy link
Contributor

Haroenv commented Feb 14, 2018

That makes sense. Do you want to make a PR for this? Relevant code can be added here:

this.$emit('page-change');

@VinceG
Copy link
Contributor Author

VinceG commented Feb 14, 2018

@Haroenv thanks, will do.

VinceG pushed a commit to VinceG/vue-instantsearch that referenced this issue Feb 14, 2018
Haroenv pushed a commit that referenced this issue Feb 15, 2018
#394)

* #393 - Feature: pass in the page when emitting the page change event

* updated test

* updated tests
Haroenv pushed a commit to algolia/instantsearch that referenced this issue Dec 28, 2022
algolia/vue-instantsearch#394)

* algolia/vue-instantsearch#393 - Feature: pass in the page when emitting the page change event

* updated test

* updated tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants