#393 - Feature: pass in the page when emitting the page change event

[VinceG]

fixes #393

[Haroenv]

Thank you! Since people didn't expect anything in that callback, we can release this as a patch I think

[Haroenv]

Can you edit the test too? (toHaveBeenCalledWith)

vue-instantsearch/src/components/__tests__/pagination.js

Lines 93 to 118 in 40c9406

	test('it should emit a "page-change" event when page changes', () => {
	const searchStore = {
	page: 1,
	totalPages: 20,
	totalResults: 4000,
	};
	const Component = Vue.extend(Pagination);
	const vm = new Component({
	propsData: {
	searchStore,
	},
	});
	const onPageChange = jest.fn();
	vm.$on('page-change', onPageChange);
	vm.$mount();
	expect(onPageChange).not.toHaveBeenCalled();
	vm.$el
	.getElementsByTagName('li')[3]
	.getElementsByTagName('a')[0]
	.click();
	expect(onPageChange).toHaveBeenCalledTimes(1);
	});

[VinceG]

@Haroenv Done.

[Haroenv]

Thanks for adding the tests, I think you changed the wrong test though.

[Haroenv]

This should have stayed the same, it's testing that it wasn't called yet

[Haroenv]

after these lines add:

expect(onPageChange).toHaveBeenCalledWith(page);

[VinceG]

@Haroenv How about this:

test('it should emit a "page-change" event when page changes and pass in the page variable', () => {
  const searchStore = {
    page: 1,
    totalPages: 20,
    totalResults: 4000,
  };
  const Component = Vue.extend(Pagination);
  const vm = new Component({
    propsData: {
      searchStore,
    },
  });

  const onPageChange = jest.fn();
  vm.$on('page-change', onPageChange);

  vm.$mount();

  expect(onPageChange).not.toHaveBeenCalled();

  vm.$el
    .getElementsByTagName('li')[3]
    .getElementsByTagName('a')[0]
    .click();
  expect(onPageChange).toHaveBeenCalledTimes(1);

  const page = searchStore.page;
  expect(onPageChange).toHaveBeenCalledWith(page);
  expect(page).toBe(2);
});

[Haroenv]

Exactly what I meant!

[Haroenv]

Great! Thanks for your contribution. I’ll release this soon